cloop doesn't compile for 2.6.25 anymore

[DirkS]

Hi All,

This is merely just FYI:
I just tried to compile the latest cloop-2.624 with /usr/src/linux pointing to /usr/src/linux-2.6.25.7
and it croaked:


...
make modules -C /usr/src/linux M=/usr/src/cloop-2.624
make[1]: Entering directory `/usr/src/linux-2.6.25.7'-2.624
CC [M] /usr/src/cloop-2.624/compressed_loop.o
/usr/src/cloop-2.624/compressed_loop.c: In function ‘cloop_read_from_file’:
/usr/src/cloop-2.624/compressed_loop.c:226: error: implicit declaration of function ‘do_generic_file_read’
...
So I performed a quick 'find':

+> find linux-2.6.25.7 linux-2.6.24.7 -type f | xargs grep -n do_generic_file_read
linux-2.6.25.7/mm/filemap.c:880 : * do_generic_file_read - generic file read routine
linux-2.6.25.7/mm/filemap.c:892 :static void do_generic_file_read(struct file *filp, loff_t *ppos,
linux-2.6.25.7/mm/filemap.c:1227 : do_generic_file_read(filp,ppos,&desc,file_read_actor);
linux-2.6.25.7/fs/isofs/compress.c:78 : * do_generic_file_read() will handle this for us
linux-2.6.24.7/include/linux/fs.h:1846 :static inline void do_generic_file_read(struct file * filp, loff_t *ppos,
linux-2.6.24.7/mm/filemap.c:1207 : do_generic_file_read(filp,ppos,&desc,file_read_actor);
linux-2.6.24.7/fs/isofs/compress.c:78 : * do_generic_file_read() will handle this for us

Looks like kernel 2.6.25.7 is broken while 2.6.24.7 might be ok. *shrug* Just wanted to tell.
I will drop 2.6.25.x and try 2.6.24.7 tomorrow.


Have fun
D.