Bash help

[anticuchos]

Hi,

Would someone please help me on Bash? Here is a broken script. I need someone to make it work.

#!/bin/bash
echo -n "
    How are you feeling?
        Tire
        Bored
        Hungry

            Enter: " #Type how you feel

read option
   if $option 'Tire'; then
   echo "You should get some rest."

   if $option 'Bored'; then
   echo "Play a game of Frozen Bubble."

   If $option 'Hungry'; then
   echo "Order pizza!"

Would someone please fix it for me? If possible add an error prompt that will say something like "You must have made a typo. Select option again." if I choose something that is not in the options.

Also, how do I make the script stay active until I exit it? Like after the script replies me, it goes back to asking me how I feel?

Thanks in advance for the help.

[Cuddles]

anticuchos,

try this, replace your "if" statements with one big "case", havent worked out the "looping" part, conditional looping is a "structured" way, not quite sure on a way to "unconditionaly" loop, yet...

This way, you can add new entries, by adding a "something)" line, and what to do when that text is entered. The "special" "*)" condition is when "nothing else matches" within the case block...

#!/bin/bash
echo -n "
    How are you feeling?
        Tired
        Bored
        Hungry

            Enter: " #Type how you feel
  read OPTION
  case $OPTION in
     tired)
       #if $option 'Tire'; then
       echo "You should get some rest."
     ;;

     bored)
       #if $option 'Bored'; then
       echo "Play a game of Frozen Bubble."
     ;;

     hungry)
       #If $option 'Hungry'; then
       echo "Order pizza!" 
     ;;
     *)
       echo "Invalid entry: $OPTION!"
     ;;
  esac

Hope this helps,
Ms. Cuddles

[Cuddles]

anticuchos,

Just figured out the unconditional, or, "infinite" loop, for your script:

#!/bin/bash
while true
do
echo -n "
    How are you feeling?
        Tired
        Bored
        Hungry

            Enter: " #Type how you feel
  read OPTION
  case $OPTION in
     tired)
       #if $option 'Tire'; then
       echo "You should get some rest."
     ;;

     bored)
       #if $option 'Bored'; then
       echo "Play a game of Frozen Bubble."
     ;;

     hungry)
       #If $option 'Hungry'; then
       echo "Order pizza!"
     ;;
     *)
       echo "Invalid entry: $OPTION!"
     ;;
  esac 
done

Note, that, this script HAS TO BE control-C 'ed out of, or it will NEVER end...

You can always add a condition into the "case" block, like, "exit" - to allow it to exit easier...

Case closed, so to speak
Ms. Cuddles

[UnderScore]

Note, that, this script HAS TO BE control-C 'ed out of, or it will NEVER end...

wrap the script in a while -> do statement, then make the a section that changes

ExitCondition="no"
while [ $ExitCondition == "no" ] ;
do
    #Place The rest of the script here

    #under the case statement, make
    # exit do a ExitCondition="yes"
done

[Cuddles]

As UnderSxore explains, changing my script to a "conditional" while do loop, will allow easier exiting, other than the CTL-C issue... From what you stated, my assumption was you didnt want to change the script, just 1 ) make it work, 2 ) make it repeat "indeffinately"...

If you take UnderScore's idea, and my changes to your script, here is what it would look like:

#!/bin/bash
# Seed the exit condition with false...
ExitCondition="no"
# Loop your script while the exit condition is still false...
while [ $ExitCondition == "no" ] ;
do
# Output our menu selections...
echo -n "
    How are you feeling?
        Tired
        Bored
        Hungry
        -=-=-=-=-=-
        Leave to exit script

            Enter: " #Type how you feel

# Get the users input...
  read OPTION

# Begin our interogation of the users input...
  case $OPTION in
     tired)
       echo "You should get some rest."
     ;;

     bored)
       echo "Play a game of Frozen Bubble."
     ;;

     hungry)
       echo "Order pizza!"
     ;;

     leave)
       echo "Hope you are feeling better now."
       # User wants to exit, change our exit condition to true...
       ExitCondition="yes"
     ;;

     *)
       # User has made an entry that doesnt contain any of the tests we are looking for...
       # ... Output a message that they entered something that is invalid, and what they
       # entered...
       echo "Invalid entry: $OPTION!"
     ;;
  esac
done

I changed your script a little, took out the "if" statements completely, and added comments to explain more...

Hope this helps,
Ms. Cuddles

[jjmac]

One of the "if" statements in the original script had an upper-case "i" ...

"If" rather than "if"


jm

[jjmac]

plus it needs to be closed with matching "fi" statements ...