Looks fine to me, but I'd cut the swap in half. There's no way you'll need that much with a 2.4 kernel.

Can't tell you about partitioning as I always use the older script (in which case you partition with cfdisk and then copy over your /home and mount it).